Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Package: Microsoft.NuGet #67249

Merged
2 commits merged into from
Aug 2, 2022
Merged

New Package: Microsoft.NuGet #67249

2 commits merged into from
Aug 2, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jul 22, 2022 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ItzLevvie
ItzLevvie previously approved these changes Jul 22, 2022
View reviewed changes
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 22, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Hello @Trenly,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 22, 2022
@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. .exe labels Jul 23, 2022
@ghost
Copy link

ghost commented Jul 23, 2022

@Trenly,

This package appears to reference a portable application rather than an installer.

This PR is blocked until support for portable applications is implemented in:

Template: msftbot/blockingIssue/portableApplication

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jul 25, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 25, 2022
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 25, 2022
@ghost
Copy link

ghost commented Jul 25, 2022

Hello @Trenly,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 25, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 26, 2022
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Hello @Trenly,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@Trenly
Copy link
Contributor Author

Trenly commented Aug 2, 2022

Beep boop

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Aug 2, 2022
@ryfu-msft ryfu-msft self-assigned this Aug 2, 2022
@ryfu-msft ryfu-msft added Validation-Completed Validation passed and removed Manifest-Validation-Error Manifest validation failed .exe Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Hello @ryfu-msft!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 2, 2022

Hello Trenly,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit ca47c18 into microsoft:master Aug 2, 2022
@Trenly Trenly deleted the Portables/NuGet/3.5.0.1938 branch August 2, 2022 17:20
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees

@ryfu-msft ryfu-msft

Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trenly @wingetbot @ItzLevvie @denelon @ryfu-msft